-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ACVP vectors for KEM and DSA #2051
Conversation
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this update @abhinav-thales, looks good to me. Great to see that the new vectors against the external interface pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the test coverage enhancement @abhinav-thales . Would it make sense to create an issue to keep track of what you labelled "Pending Test Coverage"?
I've created #2061 to track this. |
This PR contains the following changes:
Vector Updates:
Test Additions:
Current Test Coverage:
The following ACVP vectors from the latest release are currently testable:
Pending Test Coverage:
The following ACVP vectors remain untested and will be enabled once upstream changes are available: