Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACVP vectors for KEM and DSA #2051

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

abhinav-thales
Copy link
Contributor

@abhinav-thales abhinav-thales commented Jan 24, 2025

This PR contains the following changes:

  • Vector Updates:

    • Added the latest vectors from ACVP (1.1.0.38).
    • Updated the vector-fetching script to align with the latest release.
  • Test Additions:

    • Introduced test cases for external APIs using context strings for signature generation and verification.
    • Differentiated internal and external tests for signature generation and verification.
    • Standardized deterministic and non-deterministic test cases for signature generation.

Current Test Coverage:

The following ACVP vectors from the latest release are currently testable:

  • External API Vectors: "pure" implementation.
  • Internal API Vectors: Without "external mu" implementation.

Pending Test Coverage:

The following ACVP vectors remain untested and will be enabled once upstream changes are available:

  • External API Vectors: "pre-hash" implementation.
  • Internal API Vectors: With "external mu" implementation.

Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
Signed-off-by: Abhinav Saxena <[email protected]>
@abhinav-thales abhinav-thales marked this pull request as ready for review January 27, 2025 10:59
Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @abhinav-thales, looks good to me. Great to see that the new vectors against the external interface pass.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the test coverage enhancement @abhinav-thales . Would it make sense to create an issue to keep track of what you labelled "Pending Test Coverage"?

@dstebila
Copy link
Member

LGTM. Thanks for the test coverage enhancement @abhinav-thales . Would it make sense to create an issue to keep track of what you labelled "Pending Test Coverage"?

I've created #2061 to track this.

@dstebila dstebila merged commit 4b34efe into open-quantum-safe:main Jan 29, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants