-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded build paths & modify basic workflow to build in random path #2019
Conversation
This fixes open-quantum-safe#2018 using `helpers.get_current_build_dir_name()` Signed-off-by: Iyán Méndez Veiga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
I pushed too quick before catching the train 😅 I will fix the env name in a bit, and test locally the pipeline before pushing again. |
38bc72c
to
6d00a25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @iyanmv. See the comments below, otherwise LGTM.
Signed-off-by: Iyán Méndez Veiga <[email protected]>
I put back the |
This fixes #2018 using
helpers.get_current_build_dir_name()
In addition, the basic workflow is modified to use a random build path. Hopefully, this small change will catch future changes that introduce hardcoded paths.