Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded build paths & modify basic workflow to build in random path #2019

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

iyanmv
Copy link
Member

@iyanmv iyanmv commented Dec 12, 2024

This fixes #2018 using helpers.get_current_build_dir_name()

In addition, the basic workflow is modified to use a random build path. Hopefully, this small change will catch future changes that introduce hardcoded paths.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

This fixes open-quantum-safe#2018 using `helpers.get_current_build_dir_name()`

Signed-off-by: Iyán Méndez Veiga <[email protected]>
@iyanmv iyanmv requested a review from bhess as a code owner December 12, 2024 15:21
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@iyanmv
Copy link
Member Author

iyanmv commented Dec 12, 2024

I pushed too quick before catching the train 😅 I will fix the env name in a bit, and test locally the pipeline before pushing again.

@iyanmv iyanmv force-pushed the fix-tests branch 2 times, most recently from 38bc72c to 6d00a25 Compare December 12, 2024 19:32
@iyanmv iyanmv changed the title Remove hardcoded build paths Remove hardcoded build paths & modify basic workflow to build in random path Dec 12, 2024
Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @iyanmv. See the comments below, otherwise LGTM.

.github/workflows/basic.yml Outdated Show resolved Hide resolved
.github/workflows/basic.yml Outdated Show resolved Hide resolved
.github/workflows/basic.yml Outdated Show resolved Hide resolved
@SWilson4 SWilson4 self-requested a review December 12, 2024 23:55
@iyanmv
Copy link
Member Author

iyanmv commented Dec 13, 2024

I put back the . (replacing the .. instead of nothing) at the end of each cmake command.

@SWilson4 SWilson4 merged commit 51708b6 into open-quantum-safe:main Dec 13, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release broke (again) tests when not using default build directory
3 participants