Add cpp linking test

[aidenfoxivey]

Accidentally deleted #1944 and as a result I've remade the PR. I'll make sure to clean up the commits prior to merging if there's any desire to change what I've written here.

I've applied the advice from earlier to move the C++ example to .github and added a workflow to basic.yml.

[aidenfoxivey]

I think I'll need to run CI to test whether basic.yml runs with changes - but I assume that's only something that reviewers and other org members can do.

[Martyrshot]

Hm. @dstebila It seems like I lost the ability to unblock ci.

[aidenfoxivey]

@Martyrshot Just to be certain, this is the location you had in mind for the C++ file, right?

[Martyrshot]

Yes that's what I meant! Once CI is able to be run, I will give this a review. Initial scim looks good though!

[dstebila]

Hm. @dstebila It seems like I lost the ability to unblock ci.

You're still listed on the liboqs-committers team so I would think you have the ability to unblock. @ryjones, any ideas? Could it be cause Aiden's PR is in his own fork?

[SWilson4]

For what it's worth, I'm also not seeing any pending CI jobs here, and I certainly have perms to unblock them. I wonder if it's because there's a merge conflict in the basic workflow file?

[aidenfoxivey]

For what it's worth, I'm also not seeing any pending CI jobs here, and I certainly have perms to unblock them. I wonder if it's because there's a merge conflict in the basic workflow file?

Maybe I can amend the commit to avoid having the merge conflict.

[aidenfoxivey]

Alright, we have a rather predictable issue with the path lol. I'll sort that out.

[ryjones]

I clicked this button - did nobody else see it?

[ryjones]

So yes, it didn't run because it is on a fork, so it needs approval

[ryjones]

I might rebase your commit on top of main instead of having a merge commit

[ryjones]

I tried a rebase but there is a merge conflict

[aidenfoxivey]

I tried a rebase but there is a merge conflict

Yeah, I had the same exact experience unfortunately. My git knowledge is not that good if I'm being honest.

[ryjones]

OK I re-wrote the commit let's see how it goes. I suspect the test cpp file needs to live elsewhere

[ryjones]

OK @aidenfoxivey I think you can drive from here, I'll stop messing about

[aidenfoxivey]

OK @aidenfoxivey I think you can drive from here, I'll stop messing about

Sounds good!

[aidenfoxivey]

I suspect the issue is the prepended /.

[ryjones]

@aidenfoxivey I restored the empty file

[aidenfoxivey]

@aidenfoxivey I restored the empty file

awesome! let's see how this run goes

[ryjones]

@aidenfoxivey are you able to build this locally?

[aidenfoxivey]

@aidenfoxivey are you able to build this locally?

yeah, locally it seems fine - that's what's confusing me.

[aidenfoxivey]

I'm honestly a little bit confused. From what I can tell, this is the current name of the c++ file. Perhaps I'm misunderstanding what the current directory is in Github actions?

[ryjones]

maybe do an ls -lR .* at the top?

[aidenfoxivey]

let's give this a go

[aidenfoxivey]

Whoops!

[aidenfoxivey]

Okay, sorted it out.

[aidenfoxivey]

Hmm, so, if I understand correctly this is running from build, but somehow the header file isn't being found.

[ryjones]

@aidenfoxivey let me know when it is safe to rewrite your commit tree to make it shorter :)

[ryjones]

Please see #1963

[ryjones]