improve algorithm documentation [skip ci] #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWilson4
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
LGTM barring one typo. Thanks to The Incredible Baentsch for putting this together. 😜
Co-authored-by: Spencer Wilson <[email protected]>
dstebila
reviewed
Mar 7, 2024
SWilson4
reviewed
Mar 7, 2024
Co-authored-by: Spencer Wilson <[email protected]>
baentsch
commented
Mar 7, 2024
SWilson4
reviewed
Mar 7, 2024
dstebila
approved these changes
Mar 7, 2024
Eddy-M-K
pushed a commit
to Eddy-M-K/liboqs
that referenced
this pull request
Apr 5, 2024
Co-authored-by: Spencer Wilson <[email protected]> Signed-off-by: Eddy Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564 : @dstebila please check whether this is enough to close out the remaining blocker for the release of 0.10.0. A full resolution may entail introducing a new algorithm class "STD-track" as discussed elsewhere (leaving only "ML-KEM" and "ML-DSA" in the STD designation). But IMO this warrants some more deliberation and should not stop 0.10.0.