Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: tests(e2e): increase CI for sampling test #19519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MINOR: tests(e2e): increase CI for sampling test #19519

wants to merge 1 commit into from

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jan 24, 2025 •
edited
Loading

Currently fails about one in 20 runs. This will fail one in 100.

based on experiment in https://gist.github.com/sushi30/3083e96c9081371fa55e55b0847b96d2

Describe your changes:

Figure_1

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner January 24, 2025 14:12
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 24, 2025
@sushi30 sushi30 enabled auto-merge (squash) January 24, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

@IceS2 IceS2 IceS2 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushi30 @IceS2 @TeddyCr