Fix responsiveness of Links (QR) page #687
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #638.
The page was not responsive on mobile and long texts were spilling out of their containers.
That has been fixed by adjusting the height of the buttons and wrapping texts.
The downside of this is that the buttons no longer have equal height, but I do not think this is a deal breaker.
Note for reviewers:
An alternative fix would be to set overflow to hidden, add display ellipsis (...) when text overflows and prevent text from wrapping with
nowrap
. The disadvantage is that users will not see some of the text.Thanks for taking the time to review! ❤️