Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsiveness of Links (QR) page #687

Closed
wants to merge 6 commits into from

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Oct 15, 2023

This PR fixes issue #638.
The page was not responsive on mobile and long texts were spilling out of their containers.
That has been fixed by adjusting the height of the buttons and wrapping texts.

Screenshot (580)

The downside of this is that the buttons no longer have equal height, but I do not think this is a deal breaker.

Screenshot (581)

Note for reviewers:
An alternative fix would be to set overflow to hidden, add display ellipsis (...) when text overflows and prevent text from wrapping with nowrap. The disadvantage is that users will not see some of the text.

.links {
    .button {
      display: inline-block; /* Make sure the button takes the width of its content */
      white-space: nowrap;
      overflow: hidden; /* Hide overflow text */
      text-overflow: ellipsis; /* Display ellipsis (...) when text overflows */
    }
  }
}

Screenshot (582)

Thanks for taking the time to review! ❤️

@bebatut
Copy link
Member

bebatut commented Nov 6, 2023

It does not work for me locally:
image

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 0e2ea25
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/66a374698903990008d4cdaa
😎 Deploy Preview https://deploy-preview-687--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yochannah
Copy link
Member

addressed in #860

@yochannah yochannah closed this Jul 29, 2024
@NPDebs NPDebs deleted the Links_page branch October 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants