Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass --game to goalc #380

Merged
merged 3 commits into from
Nov 8, 2023
Merged

pass --game to goalc #380

merged 3 commits into from
Nov 8, 2023

Conversation

dallmeyer
Copy link
Collaborator

haven't tested yet

Comment on lines 573 to 575
"--game",
&game_name,
])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to do a check like the other functions and conditionally add the flag, since older tooling versions will fail over "unexpected arg"

// Add new --game argument
if config_info.tooling_version.minor > 1 || config_info.tooling_version.patch >= 44 {
args.push("--game".to_string());
args.push(game_name.clone());
}

Although.,..this is goalc. It'll be a different version...we'll have to see when we added the --game arg to goalc first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a hack but we could only do it for jak 2? I assume goalc has supported it since before the jak 2 release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that should be a fine temporary hack, can be replaced with a proper version check eventually

@xTVaser xTVaser merged commit fc70da1 into open-goal:main Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants