-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generics for InMemoryProvider Flag config #1046
Draft
wichopy
wants to merge
1
commit into
open-feature:main
Choose a base branch
from
wichopy:wichopy/inMemoryProvider-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−4
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,15 +10,15 @@ type Variants<T> = Record<string, T>; | |
/** | ||
* A Feature Flag definition, containing it's specification | ||
*/ | ||
export type Flag = { | ||
export type Flag<V = Variants<boolean> | Variants<string> | Variants<number> | Variants<JsonValue>> = { | ||
/** | ||
* An object containing all possible flags mappings (variant -> flag value) | ||
*/ | ||
variants: Variants<boolean> | Variants<string> | Variants<number> | Variants<JsonValue>; | ||
variants: V; | ||
/** | ||
* The variant it will resolve to in STATIC evaluation | ||
*/ | ||
defaultVariant: string; | ||
defaultVariant: keyof V; | ||
/** | ||
* Determines if flag evaluation is enabled or not for this flag. | ||
* If false, falls back to the default value provided to the client | ||
|
@@ -30,7 +30,26 @@ export type Flag = { | |
* If it does not return a valid variant it falls back to the default value provided to the client | ||
* @param EvaluationContext | ||
*/ | ||
contextEvaluator?: (ctx: EvaluationContext) => string; | ||
contextEvaluator?: (ctx: EvaluationContext) => keyof V; | ||
}; | ||
|
||
// sample | ||
const flag: Flag<{ | ||
hi: boolean, | ||
bye: boolean, | ||
}> = { | ||
variants: { | ||
'hi': true, | ||
bye: false, | ||
}, | ||
disabled: false, | ||
defaultVariant: 'hi', | ||
contextEvaluator: (ctx: EvaluationContext) => { | ||
if (ctx.user === '[email protected]') { | ||
return 'bye'; | ||
} | ||
return 'hi'; | ||
}, | ||
}; | ||
|
||
export type FlagConfiguration = Record<string, Flag>; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was there for testing?