test(flagd): add socket path tests #1153
Conversation
aepfli
commented
Jan 11, 2025
aepfli
commented
- finding, socket path is not supported for in_process
Signed-off-by: Simon Schrottner <[email protected]>
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
| @Suite(failIfNoTests = false) | ||
| @IncludeEngines("cucumber") | ||
| // Not implemented in flagd | ||
| //@SelectFile("spec/specification/assets/gherkin/evaluation.feature") |
There was a problem hiding this comment.
again, this does not work for in_process connection
|
@aepfli I'm not sure if you noticed, but there's an OOM error in the CI. |
|
Yes, I have seen it, and I am currently also investigating. This is an odd issue. How do you simulate a reconnect with an SSL socket? I am not sure this is something testable, as a socket connection is a file connection. and imho, if that gets delete, i don't think we can recover, wdyt? |
I think we should avoid reconnection tests for the file mode. I don't think they make sense and I don't even know if it's possible. Definitionally, a unix socket should be on a shared disk; if that disk is not accessible I think it's out of our hands and probably we don't need to support reconnection. Really the socket is to enable very fast local communication by avoiding the TCP stack. |
|
Superseded by #1115 |
