Singal PDU dataLength should be in bits, not bytes (DIS 6) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leif81
reviewed
Jul 31, 2023
leif81
reviewed
Jul 31, 2023
|
Thank-you for the pull request @intothevoid ! I've reviewed it and have left two comments. Can you please take a look and respond when you can. Thanks |
intothevoid
force-pushed
the
fix/data-length-issue
branch
from
b4b6d8e to
b56567b
Compare
|
I've removed the formatting changes and pushed the changes to the PR. Let me know if you need more changes. Commit here: b56567b |
leif81
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec, the data length is meant to be indicated in bits, not bytes. I've used the fix in the Java version of open-dis as a basis for this pull request. See open-dis/open-dis-java@9b20d4d#diff-5d13a4f131b76879516bb03083caae46
Related issues here: #10 and here: #84