Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 refator gc and move rbac deletion to cluster controller #831

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhiweiyin318
Once this PR has been reviewed and has the lgtm label, please assign skeeey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 45 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (568789f) to head (f3c22f2).

Files with missing lines Patch % Lines
pkg/registration/hub/managedcluster/controller.go 48.61% 27 Missing and 10 partials ⚠️
pkg/registration/hub/gc/controller.go 64.70% 5 Missing and 1 partial ⚠️
pkg/registration/hub/gc/gc_resources.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   63.85%   63.75%   -0.11%     
==========================================
  Files         193      192       -1     
  Lines       18663    18640      -23     
==========================================
- Hits        11917    11883      -34     
- Misses       5765     5780      +15     
+ Partials      981      977       -4     
Flag Coverage Δ
unit 63.75% <58.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant