Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adding Guidewire team members to registration owners #796

Conversation

jaswalkiranavtar
Copy link
Contributor

Summary

Making guidewire members owner of aws registration

Related issue(s)

#514

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and xuezhaojun January 9, 2025 14:26
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.81%. Comparing base (037aa3c) to head (26975e6).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
+ Coverage   63.78%   63.81%   +0.02%     
==========================================
  Files         192      192              
  Lines       18606    18613       +7     
==========================================
+ Hits        11868    11878      +10     
+ Misses       5759     5757       -2     
+ Partials      979      978       -1     
Flag Coverage Δ
unit 63.81% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that all the members are in the OCM org.

@jaswalkiranavtar @suvaanshkumar @ramekris3163 @amrcoder @jeffw17

Please ensure two-factor authentication is enabled on your GitHub accounts or the CNCF bot will do something mean to you :)

@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaswalkiranavtar, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@jaswalkiranavtar
Copy link
Contributor Author

Confirmed with all team members that 2FA is enabled.

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7261646 into open-cluster-management-io:main Jan 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants