Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt latest changes for agentqna #701

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

yongfengdu
Copy link
Collaborator

Use stream to follow OpenAI's API.
Rename the image name from agent-langchain to agent.

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

closed #668 #670

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao added this to the v1.2 milestone Jan 16, 2025
Copy link
Collaborator

@Ruoyu-y Ruoyu-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just a minor issue

helm-charts/common/agent/templates/tests/test-pod.yaml Outdated Show resolved Hide resolved
Use stream to follow OpenAI's API.
Rename the image name from agent-langchain to agent.
Fix test input

Signed-off-by: Dolpher Du <[email protected]>
@yongfengdu yongfengdu merged commit 88a7b52 into opea-project:main Jan 16, 2025
10 checks passed
@yongfengdu yongfengdu deleted the stream branch January 16, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci-auto] rename streaming to stream in AgentQnA,AudioQnA
4 participants