Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csp] add terraform layer #520

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[csp] add terraform layer #520

merged 2 commits into from
Nov 6, 2024

Conversation

poussa
Copy link
Collaborator

@poussa poussa commented Nov 1, 2024

Description

Add additional layer to cloud-service-provider directory tree. Moving forward, the proposed structure will be:

cloud-service-provider/<csp>/<solution>/<tool>, where

csp: aws, google-cloud, azure, etc
solution: eks, sagemaker, gke, cloudrun, aks, etc
tool: terraform, cloudformation, bash, ansible, etc

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a.

Tests

n/a.

@poussa poussa removed the request for review from mkbhanda November 1, 2024 07:07
@poussa
Copy link
Collaborator Author

poussa commented Nov 1, 2024

@smguggen PTAL

@poussa poussa requested review from lianhao and mkbhanda and removed request for daisy-ycguo November 1, 2024 07:57
@lianhao
Copy link
Collaborator

lianhao commented Nov 6, 2024

@poussa Please fix the DCO error to unblock the merge

Signed-off-by: Sakari Poussa <[email protected]>
@poussa
Copy link
Collaborator Author

poussa commented Nov 6, 2024

@poussa Please fix the DCO error to unblock the merge

Fixed.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for @poussa ! LGTM

@lianhao lianhao merged commit c476fde into opea-project:main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants