Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement mod api models #176

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Conversation

imadbourouche
Copy link
Member

@imadbourouche imadbourouche commented Jan 9, 2025

Context

This pull request introduces the core models for the MOD-API, which are essential for managing semantic artefacts and their distributions.

Implemented Models

  1. Semantic Artefact

    • Represents a semantic artefact with relevant metadata and properties.
  2. Semantic Artefact Distribution

    • Represents a distribution of a semantic artefact, specifying its format and accessibility.
  3. Attributes that the models include are in this GSheet

Summary

These models serve as the foundation for the MOD-API and will be used to facilitate data retrieval and management of semantic artefacts and their distributions.

imadbourouche

This comment was marked as outdated.

@syphax-bouazzouni syphax-bouazzouni removed their request for review January 10, 2025 07:44
@imadbourouche imadbourouche marked this pull request as draft January 10, 2025 09:48
@imadbourouche imadbourouche marked this pull request as ready for review January 20, 2025 15:27
lib/ontologies_linked_data/models/mod/semantic_artefact.rb Outdated Show resolved Hide resolved
lib/ontologies_linked_data/models/mod/semantic_artefact.rb Outdated Show resolved Hide resolved
test/models/mod/test_artefact.rb Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 89.87854% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (a680ef1) to head (1e2ec8b).
Report is 11 commits behind head on development.

Files with missing lines Patch % Lines
...logies_linked_data/models/mod/semantic_artefact.rb 86.12% 24 Missing ⚠️
..._data/models/mod/semantic_artefact_distribution.rb 98.64% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #176      +/-   ##
===============================================
+ Coverage        82.44%   82.70%   +0.26%     
===============================================
  Files              103      105       +2     
  Lines             6834     7031     +197     
===============================================
+ Hits              5634     5815     +181     
- Misses            1200     1216      +16     
Flag Coverage Δ
unittests 82.70% <89.87%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imadbourouche imadbourouche merged commit 6e0361a into development Jan 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants