Merge to master: Release 3.0.3 #926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#902) * display accessible private ontologies in user account settings * show Accessible Ontologies section in user account page only when the list of accessible ontologies is not empty * make show private ontologies only filter on browse page displayed for all users (not only for admins) * show private only switch in browse page only for logged in users
…deselecting (#773) * update categories selector in admin page to allow multiple parentCategories * handle category multiple parents in category page * add null safety in nest categories children function * check children inputs of a category when we check it * deselect children of category when we delect it in browse page * make the click categories action works only with categories input chips in browse page * fix check method in categories controller to select parents of a child when selected and deselect children of parent when deselected * change the name of categories stimulus controller to parent categories selector * associate categories with their parents in upload ontology form chips * update the logic of associating parent categories with their children to select or deselect children with their parents * refactor parent categories selector controller code * move categories with children logic from stimulus controller to ruby part * remove duplicated id_to_acronym method --------- Co-authored-by: Syphax <[email protected]>
* fix self portal tooltip not working in the home page * make portal_config_tooltip method in home helper null safe
…ache expires in 10 minutes (#908) * make portals status cache expires in 10 minutes * fix browse categories issue when a portal is down
…it forms (#906) * add a method to convert categories with children list to categories with parents list * pass categories with parents list to the parent categories selector stimulus controller * fix the logic to distinguish between browse page, and upload/edit forms * clean parents categories selector stimulus controller code to remove redendence * add a comment to explain browse page logic and upload/edit forms logic in parent categories selector stimulus controller
…equest portals instead of all portals (#913)
…a fast way (#911) * fix white page issue when load multiple turbo frames * replace settimeout of 0 by requestAnimationFrame
* add list items component to hide container items if more than max items * use list item component in concept details component for synonyms and others * fix show edge case where max items is equal to the items total length * remove an cyclic include raising an exception
syphax-bouazzouni
force-pushed
the
master
branch
2 times, most recently
from
5e9d0e4 to
9489de1
Compare
syphax-bouazzouni
requested changes
Feb 2, 2025
| label = label.to_h.reject { |key, _| %i[links context].include?(key) } if label.is_a?(OpenStruct) | ||
|
|
||
| if label.is_a?(String) | ||
| content_tag(:p, label) | ||
| elsif label.is_a?(Array) | ||
| content_tag(:div) do | ||
| raw(label.map { |x| content_tag(:div, x) }.join) | ||
| list_items_component(max_items: show_max) do |r| |
There was a problem hiding this comment.
there is a bug here, show_max and style_as_badge variables are not present.
There was a problem hiding this comment.
* delete unnecessary components from the lookbook * move loader component and notification component to the display folder in the lookbook preview * add empty state component to the lookbook * add icon with tooltip buttons to lookbook * update pill button in the lookbook * add list items component to the look * remove component preview component from the lookbook * fix ListItemsShowMoreComponent was not displayed properly on lookbook * update usages of empty state
…ly if visited (#912) * make the ontology viewer load the sections only if visited * update the ontology viewer to lazy the section that are not data
* use the new ruby client explore DSL to prevent unnecessary calls * use development branch of API client
…#934) * fix display_in_multiple_languages method to add the missing params * make the default value of show max in display_in_multiple_languages method 5
* update test config file * add system federation tests to test basic browse and search pages federation * peforme federated search in search page and make sure federation is working * perform federated browse and make sure federation is working * make sure federated categories are working on browse page * federate only with one portal to make requests faster * add comments to explain federation tests * test federated search and browse pages when a portal is down * fix a merging issue in display_in_multiple_languages * fix annotator url in test config to make tests pass * update test configs to minimize changes to play safe * use development branch for client gem --------- Co-authored-by: s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes