Fix: auto deploy on push issue #917
Draft
+31
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
requested changes
Jan 15, 2025
Bilelkihal
changed the title
syphax-bouazzouni
changed the title
syphax-bouazzouni
requested changes
Jan 30, 2025
| echo "TARGET=${USER_INPUT_ENVIRONMENT:-staging}" >> $GITHUB_ENV | ||
| # Set default environment for push events | ||
| if [ "${{ github.event_name }}" = "push" ]; then | ||
| TARGET="staging" # Default to staging for push |
There was a problem hiding this comment.
don't default push into stage, it need to check the current pushed branch and depending on it decide where to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While reviewing the deployment workflow, I noticed that deployment on push is enabled, but it is currently not working. After checking the logs, I found the following error preventing the deployment:
Changes