Skip to content

Commit

Permalink
Remove SimpleCov for 2.99.3 and later
Browse files Browse the repository at this point in the history
- Breaks Travis because of the support for pre-Ruby 2.x.
  • Loading branch information
halostatue committed Sep 11, 2016
1 parent 6079452 commit 60eb103
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 41 deletions.
4 changes: 4 additions & 0 deletions History.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
* Minor improvement to the support build script to only extract supported MIME
type name characters from obsoletion or deprecation notes.

* Removed SimpleCov from the build process. The code here is no longer
changing, and its presence causes substantial breakage on Travis for Rubies
that are not 2.x-compatible.

== 2.99.2 / 2016-05-21

* Data release. This release reflects updates to the embedded MIME type data on
Expand Down
33 changes: 0 additions & 33 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ spec = Hoe.spec 'mime-types' do
extra_dev_deps << ['rake', '~> 10.0']
extra_dev_deps << ['fivemat', '~> 1.3' ]
extra_dev_deps << ['minitest-rg', '~> 5.2']

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.0')
extra_dev_deps << ['simplecov', '~> 0.7']
extra_dev_deps << ['coveralls', '~> 0.8']
end
end

task :support do
Expand Down Expand Up @@ -97,34 +92,6 @@ namespace :benchmark do
end
end

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.0')
namespace :test do
task :coveralls do
spec.test_prelude = [
'require "psych"',
'require "simplecov"',
'require "coveralls"',
'SimpleCov.formatter = Coveralls::SimpleCov::Formatter',
'SimpleCov.start("test_frameworks") { command_name "Minitest" }',
'gem "minitest"'
].join('; ')
Rake::Task['test'].execute
end

desc 'Run test coverage'
task :coverage do
spec.test_prelude = [
'require "simplecov"',
'SimpleCov.start("test_frameworks") { command_name "Minitest" }',
'gem "minitest"'
].join('; ')
Rake::Task['test'].execute
end
end

Rake::Task['travis'].prerequisites.replace(%w(test:coveralls))
end

namespace :mime do
desc 'Download the current MIME type registrations from IANA.'
task :iana, [ :destination ] => 'support:nokogiri' do |_, args|
Expand Down
8 changes: 0 additions & 8 deletions mime-types.gemspec
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# -*- encoding: utf-8 -*-
# stub: mime-types 2.99.3 ruby lib

coverage = Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.0')

Gem::Specification.new do |s|
s.name = "mime-types"
s.version = "2.99.3"
Expand Down Expand Up @@ -38,8 +36,6 @@ Gem::Specification.new do |s|
s.add_development_dependency(%q<rake>, ["~> 10.0"])
s.add_development_dependency(%q<fivemat>, ["~> 1.3"])
s.add_development_dependency(%q<minitest-rg>, ["~> 5.2"])
s.add_development_dependency(%q<simplecov>, ["~> 0.7"]) if coverage
s.add_development_dependency(%q<coveralls>, ["~> 0.8"]) if coverage
s.add_development_dependency(%q<hoe>, ["~> 3.15"])
else
s.add_dependency(%q<minitest>, ["~> 5.9"])
Expand All @@ -54,8 +50,6 @@ Gem::Specification.new do |s|
s.add_dependency(%q<rake>, ["~> 10.0"])
s.add_dependency(%q<fivemat>, ["~> 1.3"])
s.add_dependency(%q<minitest-rg>, ["~> 5.2"])
s.add_dependency(%q<simplecov>, ["~> 0.7"]) if coverage
s.add_dependency(%q<coveralls>, ["~> 0.8"]) if coverage
s.add_dependency(%q<hoe>, ["~> 3.15"])
end
else
Expand All @@ -71,8 +65,6 @@ Gem::Specification.new do |s|
s.add_dependency(%q<rake>, ["~> 10.0"])
s.add_dependency(%q<fivemat>, ["~> 1.3"])
s.add_dependency(%q<minitest-rg>, ["~> 5.2"])
s.add_dependency(%q<simplecov>, ["~> 0.7"]) if coverage
s.add_dependency(%q<coveralls>, ["~> 0.8"]) if coverage
s.add_dependency(%q<hoe>, ["~> 3.15"])
end
end

0 comments on commit 60eb103

Please sign in to comment.