Fix empty column selector #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Bartet
force-pushed
the
fix_empty_column_selector
branch
2 times, most recently
from
d3f7d4b to
f5be77c
Compare
|
@xadupre this one is ready for review (and I turned the non ready one into a draft). |
added 3 commits
January 24, 2025 11:45
Signed-off-by: Pierre Bartet <[email protected]>
Signed-off-by: Pierre Bartet <[email protected]>
Signed-off-by: Pierre Bartet <[email protected]>
Pierre-Bartet
force-pushed
the
fix_empty_column_selector
branch
from
b6e5459 to
1dcc815
Compare
|
Are the workflows run automatically when pushing a new commit or do you have to approve each run each time ? |
|
I have to approve. |
|
Sorry for not running Black before pushing then ^^ |
xadupre
approved these changes
Jan 24, 2025
|
Should I merge? |
|
This is a one liner fix and all the existing and added tests pass so yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155 by skipping transforms with no corresponding columns at all, and add the corresponding test.