Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pybind11 to version 2.12.0 #3088

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

chentong319
Copy link
Collaborator

@chentong319 chentong319 commented Feb 26, 2025

The old version of pybind11 is too old for python version 3.12. I got error when building onnx-mlir locally with python version 3.12.2.
The PR update pybind11 to version 2.12.0, which is the version used by onnx.
With this PR, I am able to run inference correctly.

Signed-off-by: Chen Tong <[email protected]>
Copy link
Collaborator

@gongsu832 gongsu832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chentong319 chentong319 merged commit 3a3dc27 into onnx:main Feb 27, 2025
7 checks passed
@chentong319 chentong319 deleted the pybind-v2.12 branch February 27, 2025 16:32
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16354 [push] pybind11 new version (#3... started at 10:32

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16357 [push] pybind11 new version (#3... started at 11:33

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15338 [push] pybind11 new version (#3... started at 11:44

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16354 [push] pybind11 new version (#3... passed after 1 hr 24 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16357 [push] pybind11 new version (#3... passed after 1 hr 30 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15338 [push] pybind11 new version (#3... passed after 2 hr 25 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants