List all templates (MVP) (#2)

onflowser · Nov 12, 2023 · b61c39c · b61c39c
2 parents 8187c64 + adc2067
commit b61c39c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 20 deletions.
diff --git a/api/src/routes/template.ts b/api/src/routes/template.ts
@@ -1,6 +1,4 @@
 import express, { Request, Response, Router } from "express";
-import { body } from "express-validator";
-import { validateRequest } from "../middlewares/validate-request";
 import { TemplateService } from "../services/template";
 import { genHash } from "../utils/gen-hash";
 import { mixpanelTrack } from "../utils/mixpanel";
@@ -13,18 +11,12 @@ function templateRouter(
   const router = express.Router();
 
   router.get("/templates", async (req: Request, res: Response) => {
-    const name = req.query.name as string;
+    const name = req.query.name as string | undefined;
 
     if (!name) {
-      mixpanelTrack("get_template_by_name", {
-        name,
-        status: 400,
-      });
+      const allTemplates = await templateService.getAllTemplates();
 
-      res.status(400);
-      return res.send(
-        `GET /templates-- Required query parameter "name" not provided.`
-      );
+      return res.send(allTemplates)
     }
 
     let templateId: string = "";

diff --git a/api/src/services/template.ts b/api/src/services/template.ts
@@ -26,22 +26,29 @@ class TemplateService {
     return newTemplate;
   }
 
-  async getTemplate(templateId: string) {
-    let foundTemplate: Template;
+  async getAllTemplates() {
+    const foundTemplates = await Template.query();
+
+    return foundTemplates.map(template => this.deserializeTemplateJson(template))
+  }
 
-    foundTemplate = (
+  async getTemplate(templateId: string) {
+    const foundTemplate = (
       await Template.query().where({
         id: templateId,
       })
     )[0];
 
-    let foundTemplateJson = foundTemplate?.json_string || null;
-
-    if (typeof foundTemplateJson === "string") {
-      foundTemplateJson = JSON.parse(foundTemplateJson);
-    }
+   if (foundTemplate) {
+     return this.deserializeTemplateJson(foundTemplate)
+   } else {
+     return null;
+   }
+  }
 
-    return foundTemplateJson;
+  private deserializeTemplateJson(template: Template) {
+    let foundTemplateJson = template.json_string;
+    return JSON.parse(foundTemplateJson);
   }
 
   async getTemplateByCadenceASTHash(cadenceASTHash: string, network: string) {