Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: running tests action #28

Merged
merged 16 commits into from
Feb 26, 2024
Merged

ci: running tests action #28

merged 16 commits into from
Feb 26, 2024
+53 −3

Conversation

bounteous17
Copy link
Contributor

@bounteous17 bounteous17 commented Feb 22, 2024 •
edited
Loading

Description

  • There is a new account agnostic.cms.harmonizer@proton.me managing the Contentful organization content being used for the e2e tests during the pipeline.

Related Issue

Motivation and Context

How Has This Been Tested?

  • The newly introduced pipeline requires access to the Contentful Organization mentioned before.

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@bounteous17 bounteous17 self-assigned this Feb 23, 2024
@bounteous17 bounteous17 marked this pull request as ready for review February 23, 2024 11:12
matyasjay
matyasjay previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@matyasjay matyasjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

inigomarquinez
inigomarquinez suggested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required in the GitHub action

inigomarquinez
inigomarquinez suggested changes Feb 23, 2024
View reviewed changes
inigomarquinez
inigomarquinez suggested changes Feb 23, 2024
View reviewed changes
@inigomarquinez inigomarquinez self-requested a review February 26, 2024 08:17
matyasjay
matyasjay approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@matyasjay matyasjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@bounteous17 bounteous17 merged commit e697f1d into main Feb 26, 2024
4 checks passed
@bounteous17 bounteous17 deleted the CROS-87-pipeline-executing-tests branch February 26, 2024 08:28
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inigomarquinez inigomarquinez

@matyasjay matyasjay

Assignees

@bounteous17 bounteous17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bounteous17 @inigomarquinez @matyasjay