Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cmd-buf local memory update CTS tests on L0 #2631

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Enable cmd-buf local memory update CTS tests on L0 #2631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/conformance/exp_command_buffer/update/local_memory_update.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ struct LocalMemoryUpdateTestBase
UUR_RETURN_ON_FATAL_FAILURE(
urUpdatableCommandBufferExpExecutionTest::SetUp());

if (backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) {
GTEST_SKIP()
<< "Local memory argument update not supported on Level Zero.";
}

// HIP has extra args for local memory so we define an offset for arg
// indices here for updating
hip_arg_offset = backend == UR_PLATFORM_BACKEND_HIP ? 3 : 0;
Expand Down Expand Up @@ -391,6 +386,8 @@ TEST_P(LocalMemoryUpdateTest, UpdateParametersEmptyLocalSize) {
// Test updating A,X,Y parameters to new values and local memory parameters
// to new smaller values.
TEST_P(LocalMemoryUpdateTest, UpdateParametersSmallerLocalSize) {
UUR_KNOWN_FAILURE_ON(uur::LevelZero{});

// Run command-buffer prior to update an verify output
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
nullptr, nullptr));
Expand Down Expand Up @@ -1310,4 +1307,4 @@ TEST_P(LocalMemoryUpdateTestOutOfOrder, UpdateAllParameters) {
uint32_t *new_X = (uint32_t *)shared_ptrs[3];
uint32_t *new_Y = (uint32_t *)shared_ptrs[4];
Validate(new_output, new_X, new_Y, new_A, global_size, local_size);
}
}