Don't use inheritence for L0 V2 event handles #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
force-pushed
the
ross/v2devirtualevent
branch
10 times, most recently
from
6d5ad1c to
7c026d8
Compare
pbalcer
approved these changes
Jan 29, 2025
In the future, we are going to require that handle objects have no vtable, so this change combines "native" and "pooled" event into one class. A variant is used to determine whether the event is native or pooled. For consistency, parameter order in constructors have been changed to always start with the context.
RossBrunton
force-pushed
the
ross/v2devirtualevent
branch
from
7c026d8 to
a7cd756
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 29, 2025
|
LLVM testing doesn't test L0 version 2, so I'll trust that the CI testing is sufficient and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we are going to require that handle objects have no
vtable, so this change combines "native" and "pooled" event into one
class. A variant is used to determine whether the event is native or
pooled.
For consistency, parameter order in constructors have been changed to
always start with the context.