Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] add initial Command Buffers support #2629

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Jan 28, 2025

No description provided.

@pbalcer pbalcer requested review from a team as code owners January 28, 2025 12:40
@pbalcer pbalcer requested a review from Bensuo January 28, 2025 12:40
@pbalcer
Copy link
Contributor Author

pbalcer commented Jan 28, 2025

This is a rebased and cleaned up version of #2532. I didn't want to force push to that PR to preserve the old history on that branch.

@github-actions github-actions bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Jan 28, 2025
@EwanC EwanC self-requested a review January 28, 2025 13:58
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't relax UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); at https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/exp_command_buffer/fixtures.h#L58 in the base CTS class, is this intentional?

@lslusarczyk lslusarczyk requested a review from a team as a code owner January 28, 2025 15:40
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues labels Jan 28, 2025
@lslusarczyk
Copy link
Contributor

This PR doesn't relax UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); at https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/exp_command_buffer/fixtures.h#L58 in the base CTS class, is this intentional?

Good point. Let's postpone enabling tests to next PRs. I'd like this PR to be merged soon, to be able to work further in parallel on v2 graphs.

@lslusarczyk
Copy link
Contributor

@Bensuo , @EwanC , @igchor ,
thank you for your comments. I've applied them. Please check if I've applied them correctly. Please resolve discussions which were applied correctly or please comment these discussions which you think need more work/discussion.

@github-actions github-actions bot added specification Changes or additions to the specification experimental Experimental feature additions/changes/specification labels Jan 28, 2025
@lslusarczyk lslusarczyk force-pushed the add-command-buffer-support branch from 311c7db to 7fc11dd Compare January 28, 2025 15:59
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first stage

@pbalcer pbalcer merged commit 9a53f26 into oneapi-src:main Jan 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug opencl OpenCL adapter specific issues specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants