-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] add initial Command Buffers support #2629
Conversation
This is a rebased and cleaned up version of #2532. I didn't want to force push to that PR to preserve the old history on that branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't relax UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});
at https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/exp_command_buffer/fixtures.h#L58 in the base CTS class, is this intentional?
Good point. Let's postpone enabling tests to next PRs. I'd like this PR to be merged soon, to be able to work further in parallel on v2 graphs. |
311c7db
to
7fc11dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a first stage
No description provided.