[HIP] Implement urKernelSuggestMaxCooperativeGroupCountExp for HIP #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GeorgeWeb |
GeorgeWeb
reviewed
Jan 27, 2025
source/adapters/hip/kernel.cpp
Outdated
| &MaxNumActiveGroupsPerCU, hKernel->get(), localWorkSize, | ||
| dynamicSharedMemorySize)); | ||
| detail::ur::assertion(MaxNumActiveGroupsPerCU >= 0); | ||
| // Handle the case where we can't have all SMs active with at least 1 group |
There was a problem hiding this comment.
I think AMD calls these WGPs (Work-Group Processors). SM is for Nvidia architectures.
GeorgeWeb
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit follows the implementation #1796 to support the experimental urKernelSuggestMaxCooperativeGroupCountExp, for the HIP adapter, to retrieve the maximum number of cooperative groups that can be launched on the device.
Additionally, the changes also cache the result of the hipDeviceAttributeMultiprocessorCount query which is used to calculate the device-wide maximum cooperative groups, because the HIP occupancy query used has per multiprocessor semantics.