Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidate for the v0.11.5 release tag #2599

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Candidate for the v0.11.5 release tag #2599

merged 4 commits into from
Jan 23, 2025

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jan 22, 2025 •
edited
Loading

@kbenzie
Merge pull request oneapi-src#2585 from yingcong-wu/yc-test-main/0120…
a634393 
…-on-shadow-per-type

[DeivceASAN] Make ShadowMemory one instance per type
@kbenzie
Merge pull request oneapi-src#2586 from AllanZyne/review/yang/fix_ker…
21de688 
…nel_release

[DeviceASAN] Fix kernel release order
@github-actions github-actions bot added the loader Loader related feature/bug label Jan 22, 2025
@kbenzie
Copy link
Contributor Author

kbenzie commented Jan 22, 2025

@yingcong-wu @AllanZyne there were merge conflicts due to us having merged #1536 to main branch. Please check this to make sure I've resolved those correctly.

@kbenzie kbenzie marked this pull request as ready for review January 22, 2025 16:18
@kbenzie kbenzie requested a review from a team as a code owner January 22, 2025 16:18
AllanZyne
AllanZyne approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for #2586

@yingcong-wu
Copy link
Contributor

yingcong-wu commented Jan 23, 2025 •
edited
Loading

The failed checks are expected as there is an API change with urKernelSuggestMaxCooperativeGroupCountExp, and the API is not changed for v0.11.

See in

yingcong-wu
yingcong-wu suggested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for #2605. This is a bugfix for #2585.

@kbenzie
Copy link
Contributor Author

kbenzie commented Jan 23, 2025

Please wait for #2605. This is a bugfix for #2585.

Okay, I'll merge this to UR main & intel/llvm then cherry-pick it onto this branch.

@yingcong-wu
Copy link
Contributor

Please wait for #2605. This is a bugfix for #2585.

Okay, I'll merge this to UR main & intel/llvm then cherry-pick it onto this branch.

Thank you!

@kbenzie kbenzie merged commit 688179d into oneapi-src:v0.11.x Jan 23, 2025
71 of 73 checks passed
@kbenzie kbenzie deleted the v0.11.5rc branch January 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingcong-wu yingcong-wu yingcong-wu approved these changes

@aarongreig aarongreig aarongreig approved these changes

@AllanZyne AllanZyne AllanZyne approved these changes

Assignees
No one assigned
Labels
loader Loader related feature/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbenzie @yingcong-wu @AllanZyne @aarongreig