DO NOT MERGE: Improved lifetime handling and docs of loader #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The loader now checks that all handles have been released before dropping factories. * Some arguments of functions have been marked as [alloc]. When the loader generates a handle from them, they will have an initial reference count that requires a single release. * Handles that are assigned to non-alloc pointers must exist and their reference counts are not incremented.
github-actions
bot
added
loader
|
Not needed with removal of loader handles entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropping factories.
loader generates a handle from them, they will have an initial
reference count that requires a single release.
reference counts are not incremented.