Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMDBUF] Implement kernel binary update for L0 adapter #2369

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[CMDBUF] Implement kernel binary update for L0 adapter #2369

merged 1 commit into from
Nov 27, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Nov 21, 2024

  • Implement kernel binary update in L0 adapter
  • Platform and driver query support for new extension functions
  • Update command buffer documentation to specify arg requirements for binary update

@Bensuo Bensuo requested review from a team as code owners November 21, 2024 16:59
@github-actions github-actions bot added specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 21, 2024
@Bensuo
Copy link
Contributor Author

Bensuo commented Nov 21, 2024

DPC++ PR: intel/llvm#16154

EwanC
EwanC approved these changes Nov 22, 2024
View reviewed changes
source/adapters/level_zero/platform.cpp Outdated Show resolved Hide resolved
@Bensuo Bensuo force-pushed the ben/kernel-binary-update-l0 branch from b24eb57 to 3a94806 Compare November 25, 2024 12:47
@EwanC EwanC added the v0.11.x Include in the v0.11.x release label Nov 26, 2024
@EwanC
Copy link
Contributor

EwanC commented Nov 26, 2024

@oneapi-src/unified-runtime-level-zero-write Could you review this please

pbalcer
pbalcer approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l0 lgtm, but we should merge #2351 first.

@Bensuo
[CMDBUF] Implement kernel binary update for L0 adapter
6e0bdeb 
- Implement binary update in L0 adapter
- Platform and driver query support for new extension functions
- Update command buffer documentation to specify arg requirements for binary update
@Bensuo Bensuo force-pushed the ben/kernel-binary-update-l0 branch from 3a94806 to 6e0bdeb Compare November 26, 2024 14:50
@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Nov 27, 2024
@callumfare callumfare merged commit 0a90db9 into oneapi-src:main Nov 27, 2024
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reble reble reble left review comments

@EwanC EwanC EwanC approved these changes

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification v0.11.x Include in the v0.11.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bensuo @EwanC @reble @pbalcer @callumfare