Skip to content

Commit

Permalink
Enable cmd-buf local memory update CTS tests on L0
Browse files Browse the repository at this point in the history
The CTS tests for updating local memory in command-buffer kernel
commands are currently skipped on Level-Zero. This feature is now
available in L0 drivers so the tests can be enabled.

There is a failure in `LocalMemoryUpdateTest.UpdateParametersSmallerLocalSize`
with incorrect results. Mark the individual test as failed as it needs further
investigation.
  • Loading branch information
EwanC committed Jan 28, 2025
1 parent 3a1b4c7 commit 0104ca5
Showing 1 changed file with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ struct LocalMemoryUpdateTestBase
UUR_RETURN_ON_FATAL_FAILURE(
urUpdatableCommandBufferExpExecutionTest::SetUp());

if (backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) {
GTEST_SKIP()
<< "Local memory argument update not supported on Level Zero.";
}

// HIP has extra args for local memory so we define an offset for arg
// indices here for updating
hip_arg_offset = backend == UR_PLATFORM_BACKEND_HIP ? 3 : 0;
Expand Down Expand Up @@ -391,6 +386,8 @@ TEST_P(LocalMemoryUpdateTest, UpdateParametersEmptyLocalSize) {
// Test updating A,X,Y parameters to new values and local memory parameters
// to new smaller values.
TEST_P(LocalMemoryUpdateTest, UpdateParametersSmallerLocalSize) {
UUR_KNOWN_FAILURE_ON(uur::LevelZero{});

// Run command-buffer prior to update an verify output
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
nullptr, nullptr));
Expand Down Expand Up @@ -1310,4 +1307,4 @@ TEST_P(LocalMemoryUpdateTestOutOfOrder, UpdateAllParameters) {
uint32_t *new_X = (uint32_t *)shared_ptrs[3];
uint32_t *new_Y = (uint32_t *)shared_ptrs[4];
Validate(new_output, new_X, new_Y, new_A, global_size, local_size);
}
}

0 comments on commit 0104ca5

Please sign in to comment.