Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print config errors #99

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Print config errors #99

merged 2 commits into from
Jan 8, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Dec 22, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

fixes ##94

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@lincmba lincmba force-pushed the print_config_errors branch from cfeabaf to bd3ede5 Compare December 22, 2023 11:04
lincmba added a commit that referenced this pull request Dec 22, 2023
 Succeeds #98
 Tests should run against the changes on this PR #99
 fixes #93
@lincmba lincmba mentioned this pull request Dec 22, 2023
2 tasks
@lincmba lincmba requested review from Wambere and pld January 2, 2024 07:32
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pld pld merged commit 92411e8 into main Jan 8, 2024
4 checks passed
@pld pld deleted the print_config_errors branch January 8, 2024 16:22
pld added a commit that referenced this pull request Jan 8, 2024
* Print config errors instead of exiting
 fixes ##94

* Add config tests
 Succeeds #98
 Tests should run against the changes on this PR #99
 fixes #93

---------

Co-authored-by: Peter Lubell-Doughtie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants