Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate FHIR Resources before publishing. #97

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Dec 21, 2023

fixes #87

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@lincmba lincmba requested review from pld and Wambere January 2, 2024 07:32
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! can you add some tests for this?

@pld
Copy link
Member

pld commented Jan 8, 2024

do these tests cover this pr? #100

@lincmba lincmba force-pushed the validate_before_publishig branch from 84f2c6f to 8f54c71 Compare January 25, 2024 07:20
@lincmba lincmba force-pushed the validate_before_publishig branch from 8f54c71 to b8b886e Compare January 25, 2024 07:28
@lincmba lincmba requested a review from Wambere January 25, 2024 07:28
@lincmba lincmba force-pushed the validate_before_publishig branch from b8b886e to 4f936e8 Compare January 25, 2024 07:33
Make requested changes
@lincmba lincmba force-pushed the validate_before_publishig branch from 4f936e8 to b6afa6d Compare January 25, 2024 08:13
@pld pld enabled auto-merge (squash) January 25, 2024 15:47
@pld pld merged commit 937e8ed into main Jan 25, 2024
4 checks passed
@pld pld deleted the validate_before_publishig branch January 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate FHIR resources before publishing
3 participants