Import Flags from Opensrp 1 #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wambere
commented
Feb 4, 2025
| @@ -99,7 +99,7 @@ def request(self, **kwargs): | |||
| # TODO - spread headers into kwargs. | |||
| headers = {"content-type": "application/json", "accept": "application/json"} | |||
| response = self.api_service.oauth.request(headers=headers, **kwargs) | |||
| if response.status_code == 401 or '<html class="login-pf">' in response.text: | |||
| if response.status_code == 401 or 'login' in response.text: | |||
There was a problem hiding this comment.
Initial line only worked for a html response, this should work even for a json response
|
Will be adding tests in a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #322
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide./gradlew clean assembleand run the efsity jar to verify my change fixes the issue and does not break the application