Fix regression bugs in pr 214 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 826f31a.
efsity/src/main/java/org/smartregister/command/TranslateCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/TranslateCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/TranslateCommand.java
Outdated
Show resolved
Hide resolved
|
Is it possible to capture the regression in a test case so that we can avoid future cases on the same? If high LOE you can create a ticket to track this and get this merged in for the Hotfix else you can add it to this PR. |
|
I can add the test in this PR |
ensure translation file is within the app directory
…-tooling into fix-regression-bugs-in-pr-214
…-tooling into fix-regression-bugs-in-pr-214
pld
approved these changes
Jan 16, 2025
|
@hilpitome can you please generate (and adjust if needed) a test and include that in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide