feat: improved gitoid_from_buffer, misc. fixups #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does a few things: - Refactors gitoid_from_buffer to delegate to BufReader. - Uses format_bytes::format_bytes instead of format to construct prefix for hashing. - Adds GitOid::from_reader_with_expected_length to support non-Seek-able readers and avoid cost of seeking if length is already known. - Adds GITOID_URL_SCHEME constant to replace two uses of literal string and ensure they're always consistent. - Updates FFI to support new from_reader_with_expected_length - Updates FFI to avoid double-buffering when building a GitOid from a reader, since the underlying implementation buffers. - Adds FFI support for new from_reader_with_expected_length constructor. - Renames FFI constructor from _new_from_* to _from_*, and updates C test code to use the new prefix. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/better_constructors
branch
from
0b8ea1d to
93e6824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does a few things:
prefix for hashing.
non-Seek-able readers and avoid cost of seeking if length is
already known.
literal string and ensure they're always consistent.
from a reader, since the underlying implementation buffers.
constructor.
updates C test code to use the new prefix.