feat: Implement newline normalization. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
2 times, most recently
from
74d53cd to
7fe45d7
Compare
|
Looks like my implementation isn't quite right yet. I don't have a Windows machine handy, so I'm just relying on CI here, which isn't ideal. Nonetheless, I'll get it sorted out. |
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
2 times, most recently
from
11bd89b to
a21bc33
Compare
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
from
f6927fa to
de1c5c9
Compare
|
Haha, the implementation is working but some lints are failing. I'll have to come back to fix that later. |
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
from
de1c5c9 to
5223a27
Compare
|
Looks like newline normalization is still not quite right; errors on Windows. |
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
from
337a77b to
6dcbdbb
Compare
This should ensure consistent Artifact IDs whether on Windows or Unix systems. It works by normalizing all CRLF newlines into LF newlines unconditionally. Since we don't care about roundtripping data (we don't store data at all, unlike Git), we can do this and in fact *have* to do it unconditionally to make the ID system work. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/newline-normalization
branch
from
6dcbdbb to
a8cda73
Compare
|
Haha! Finally!! Got it working on Windows. This also ended up involving some splitting out of code from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure consistent Artifact IDs whether on Windows or Unix systems.