logback.xml/logback-indexing.xml: add default scanPeriod of 1 minute #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration files used by the server components are expected to be automatically reloaded as per the scan="true" property - see https://logback.qos.ch/manual/configuration.html#autoScan. However, this behavior is currently affects by a regression introduced in logback 1.1.7 and only corrected in logback 1.3.x - see https://jira.qos.ch/browse/LOGBACK-1194 At least until we are ready to switch the codebase to logback 1.3.x, this should restore the ability to dynamically adjust the log levels of a running server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The configuration files used by the server components are expected to be automatically reloaded as per the scan="true" property - see https://logback.qos.ch/manual/configuration.html#autoScan. However, this behavior is currently affects by a regression introduced in logback 1.1.7 and only corrected in logback 1.3.x - see https://jira.qos.ch/browse/LOGBACK-1194
At least until we are ready to switch the codebase to logback 1.3.x, this should restore the ability to dynamically adjust the log levels of a running server
Testing
Without this PR, update logback.xml of a running OMERO.server e.g. by adjusting a log level to
DEBUGand watch the logs. Nothing should happen and only a server restart will allow to take the new level into account.With this PR included, the configuration change should be automatically reloaded within 1 minute and reflected in the logs
Related reading
ome/omero-blitz#137 bears some relationship as it proposes to bump the logback version shipped within the server to the 1.3.x series which should contain the fix for the original regression. Independently, we might still want to define an explicit default for the
scanPeriodin these configuration files