Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electrum mnemonic to seed support #7

Closed
wants to merge 0 commits into from

Conversation

nmarley
Copy link
Contributor

@nmarley nmarley commented Jan 25, 2016

This will allow interoperability with Electrum seeds via:

BTC::Mnemonic.new(words: ...).electrum_seed

The spec works, but I'm not sure where to put the block because it's not one of the "standard test vectors" in BIP39.

@oleganza
Copy link
Owner

Implementation seems fine by me, but I couldn't quickly find any reference to spec & test vectors. Could you please provide reference in the comment to electrum_seed method and add test vector(s) that are used in other implementations (with a reference to them from the spec source code)?

@nmarley
Copy link
Contributor Author

nmarley commented Jan 26, 2016

The only thing I could find was the Electrum test, so I used the values for that:

https://github.com/spesmilo/electrum/blob/master/lib/tests/test_mnemonic.py#L11-L15

The old mnemonic test isn't really used for modern BIP0032/0039(ish) wallets, so I didn't implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants