Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass mining fee to transaction builder #17

Closed
wants to merge 2 commits into from

Conversation

kp666
Copy link

@kp666 kp666 commented Jun 29, 2017

add spec for mining fee
refactor code

  add spec for mining fee
  refactor code
@kp666 kp666 force-pushed the change-mining-fee branch from acaee24 to bdd28ca Compare June 29, 2017 12:58
@oleganza
Copy link
Owner

I liked the previous API better: all parameters are set during init and build only wires all of them together. Why did you decide to put mining_fee argument in build?

While we are at it, lets rename it to fee, to be consistent with fee_rate.

@kp666
Copy link
Author

kp666 commented Jun 30, 2017

Well, my thinking was to create a builder object and then reuse this builder object, to build transactions with a different mining fee.

@kp666 kp666 closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants