Accept mining fee for TransactionBuilder #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction builder is computing `mining_fee` for the transaction. User/clinet is not able to set the mining fee. Enable TransactionBuilder to accept mining fee and use it as the mining fee instead of computing the fee and make sure it compute the fee unless the mining fee is not provided.
|
Context behind this PR is, I want to set minig fee explisitly for various reason. Current version computes the fee based on the rate. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction builder is computing
mining_feefor the transaction. User/client is not able to set the mining fee.Enables TransactionBuilder to accept mining fee and use it as the mining fee instead of computing the fee and make sure it compute the fee unless the mining fee is not provided.