Skip to content

Commit

Permalink
- Fixed comment typos
Browse files Browse the repository at this point in the history
  • Loading branch information
oleg-shilo committed Oct 23, 2024
1 parent f54b03f commit bfd2403
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ static public void Main()
var crtMsi = BuildCrtMsi();
var productMsi = BuildMainMsi();

SimpleMsiInternalUI(crtMsi);
// SimpleGlobalInternalUI(crtMsi);
//SimpleMsiInternalUI(crtMsi);
SimpleGlobalInternalUI(crtMsi);
// Standard(crtMsi, productMsi);
Complex(crtMsi, productMsi);
//Complex(crtMsi, productMsi);
}

static public void SimpleMsiInternalUI(string msi)
Expand Down Expand Up @@ -242,7 +242,8 @@ static public string BuildCrtMsi()
new File("readme.txt")))
{ };

crtProj.UI = WUI.WixUI_InstallDir;
//crtProj.UI = WUI.WixUI_InstallDir;
crtProj.ManagedUI = ManagedUI.Default;
crtProj.Load += CrtProj_Load;

// crtProj.BeforeInstall += args =>
Expand Down
2 changes: 2 additions & 0 deletions Source/src/WixSharp/Bootstrapper/Packages.cs
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,8 @@ public MsiPackage(string path)
/// then it is problematic. WiX team has not solved this problem since WiX3 despite the intent (https://github.com/wixtoolset/issues/issues/4921)
/// Thus the only working options for displaying custom Managed UI are:
/// </para>
/// <para>- Follow `WixBootstrapper` sample (SimpleGlobalInternalUI case). It suspends Bootstrapper UI and instead
/// shows the UIs for all packages in the bundle.</para>
/// <para> - Follow 'WixBootstrapper_MsiEmbeddedUI' sample, which shows a very simple technique of wrapping msi into a self-hosted executable included in the bundle that happily shows the MSI UI regardless of whether it is a native or a managed one.
/// </para>
/// <para>- Use NSIS bootstrapper instead. Sadly. WiX Bundle seems to be too fragile and inflexible.</para>
Expand Down

0 comments on commit bfd2403

Please sign in to comment.