fix: incorrect handling of hints in r1cs solver

okx · Nov 13, 2021 · e116a82 · e116a82
1 parent 1387c60
commit e116a82
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 6 deletions.
diff --git a/internal/backend/bls12-377/cs/r1cs.go b/internal/backend/bls12-377/cs/r1cs.go
diff --git a/internal/backend/bls12-381/cs/r1cs.go b/internal/backend/bls12-381/cs/r1cs.go
diff --git a/internal/backend/bls24-315/cs/r1cs.go b/internal/backend/bls24-315/cs/r1cs.go
diff --git a/internal/backend/bn254/cs/r1cs.go b/internal/backend/bn254/cs/r1cs.go
diff --git a/internal/backend/bw6-761/cs/r1cs.go b/internal/backend/bw6-761/cs/r1cs.go
diff --git a/internal/generator/backend/template/representations/r1cs.go.tmpl b/internal/generator/backend/template/representations/r1cs.go.tmpl
@@ -202,7 +202,12 @@ func (cs *R1CS) solveConstraint(r compiled.R1C, solution *solution) error {
 
 		// first we check if this is a hint wire
 		if hint, ok := cs.MHints[vID]; ok {
-			return solution.solveWithHint(vID, hint)
+			if err := solution.solveWithHint(vID, hint); err != nil {
+				return err
+			}
+			v := solution.computeTerm(t)
+			val.Add(val, &v)
+			return nil
 		}
 
 		if loc != 0 {