Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor orphan map #1969

Merged
merged 10 commits into from
May 4, 2022
Merged

refactor orphan map #1969

merged 10 commits into from
May 4, 2022

Conversation

zhongqiuwood
Copy link
Contributor

  • refactor orphan map
  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #1969 (75083df) into dev (5076a1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1969   +/-   ##
=======================================
  Coverage   50.84%   50.84%           
=======================================
  Files         276      276           
  Lines       19923    19923           
=======================================
  Hits        10130    10130           
  Misses       9074     9074           
  Partials      719      719           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zhongqiuwood zhongqiuwood merged commit c1d1ef0 into dev May 4, 2022
@zhongqiuwood zhongqiuwood deleted the refactor-orphan-map branch May 4, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants