Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Limit on Patient DOB values #9730

Closed
wants to merge 1 commit into from
Closed

Fix: Limit on Patient DOB values #9730

wants to merge 1 commit into from

Conversation

SathishAdithiyaaSV
Copy link
Contributor

@SathishAdithiyaaSV SathishAdithiyaaSV commented Jan 4, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

Video of Solution:

Screencast.from.2025-01-04.11-40-48.webm

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Simplified date of birth input with a single calendar-based date selection field
    • Improved date input validation and formatting

  • Bug Fixes

    • Enhanced error handling for date of birth input

@SathishAdithiyaaSV SathishAdithiyaaSV requested a review from a team as a code owner January 4, 2025 06:14
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2025 •
edited
Loading

Walkthrough

The pull request modifies the PatientRegistration component by replacing individual day, month, and year input fields with a single, standard HTML date input. This change simplifies the date of birth entry process by providing a calendar-based selection method. The implementation uses an <Input> component of type "date", which inherently provides formatting and basic validation for date input.

Changes

File Change Summary
src/components/Patient/PatientRegistration.tsx Replaced separate day, month, year inputs with a single date input field

Assessment against linked issues

Objective Addressed Explanation
Limit DOB values [#9725] ✅ Native date input provides built-in validation for date ranges

Possibly related PRs

Suggested labels

tested, needs review, P1

Suggested reviewers

  • rithviknishad
  • khavinshankar

Poem

🐰 A rabbit's tale of dates so neat,
One field to pick, no more repeat!
Calendar dancing, validation tight,
Patient forms now shine so bright! 📅
Simplicity wins the coding fight! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68c4c3d and d6d73e1.

📒 Files selected for processing (1)
  • src/components/Patient/PatientRegistration.tsx (1 hunks)
🔇 Additional comments (1)
src/components/Patient/PatientRegistration.tsx (1)

448-461: Consider validating domain constraints for date_of_birth.

Currently, the min attribute is set to "1900-01-01" and max is the current date. Verify whether this range is acceptable for all older patients. If there's an upper-limit requirement (e.g., max 120 years old), consider enforcing it in the component or through form validation logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit d6d73e1
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6778d1d48eca9a0008f534b3
😎 Deploy Preview https://deploy-preview-9730--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish
Copy link
Member

bodhish commented Jan 4, 2025

Keeping it as 3 input was a design choice. Picking date of birth using calendar is really hard.

@bodhish bodhish closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit on patient DOB values
2 participants
@SathishAdithiyaaSV @bodhish