hide location filter if facility is not selected

[ayush-seth]

WHAT

🤖[deprecated] Generated by Copilot at c3bb44d

This pull request introduces some improvements and new features for the form and filter components in the frontend. It adds a LocationSelect component and a SelectMenuV2 component, which allow users to select locations and other options more easily. It also fixes some issues with error handling and code style in FormField.tsx and PatientFilter.tsx.

Proposed Changes

• Fixes Advanced filter on patient: Location (Improvement) #6671
• 50080e6 Make the error field in LocationSelect optional instead of required and make the error component in FormField render only if an error is present. This now makes sure that we don't have an empty span taking up space on the screen even if there is no error. This was causing extra space below the location filter and negative margin was being used to fix that earlier.
• 431cf7b Remove unnecessary tailwind classes and negative margin mentioned above as the extra space issue is now fixed by not rendering the error span. No reason to use grid/flex properties for a simple top-down form.
• c3bb44d Render the location filter only if a facility is selected

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

HOW

🤖[deprecated] Generated by Copilot at c3bb44d

• Make errors prop optional in LocationSelectProps interface (link)
• Reorder and group import statements in LocationSelect.tsx and PatientFilter.tsx (link, link, link, link)
• Conditionally render FieldErrorText component in FormField component (link)
• Change className prop of AccordionV2 component to rounded-md and use space-y-4 for accordion content in PatientFilter.tsx (link)
• Conditionally render LocationSelect component in PatientFilter.tsx and remove unnecessary props (link)
• Remove unused className props from div elements containing FieldLabel components in PatientFilter.tsx (link, link)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 22, 2023 5:06am

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	9e253d4
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/655d8c1c4ec7af0008389de1
😎 Deploy Preview	https://deploy-preview-6688--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rithviknishad]

Nice work!

[nihal467]

LGTM