Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra padding in appointment details page | Current status dropdown #10423

Merged

Conversation

Mahendar0701
Copy link
Contributor

@Mahendar0701 Mahendar0701 commented Feb 5, 2025

Proposed Changes

Remove extra padding in appointment details page in mobile view

Previous:

Image

Now:

Image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Improved the appointment details view with enhanced spacing and responsiveness for better visual consistency across various screen sizes.
    • Updated button layout and margins for improved usability on different devices.
  • Bug Fixes
    • Added event handling to prevent unintended interactions with the dropdown component.

@Mahendar0701 Mahendar0701 requested a review from a team as a code owner February 5, 2025 14:11
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

The pull request updates the styling of the AppointmentDetail component to improve its responsiveness. Changes include adding and modifying CSS classes (e.g., md:p-4, mt-4 md:mt-0, md:mx-6, md:p-6) so that padding and margins adjust appropriately between mobile and medium/larger screen sizes. The updates affect only the layout and visual appearance without altering the underlying component logic.

Changes

File Path Change Summary
src/pages/Appointments/AppointmentDetail.tsx Updated responsive styling: added md:p-4 to appointment token card, modified button container with mt-4 md:mt-0, added md:mx-6 and md:p-6.
src/pages/Appointments/AppointmentsPage.tsx Added onClick handler to prevent event propagation on the AppointmentStatusDropdown component.

Assessment against linked issues

Objective Addressed Explanation
Remove extra padding in appointment details page in mobile view (#10422)
Current status dropdown is not working in appointments list view for mobile view (#10424)

Possibly related PRs

Suggested labels

needs review, tested

Suggested reviewers

  • Jacobjeevan

Poem

In the code garden I hop with glee,
Adjusting margins so elegantly free.
With a twitch of my nose and a joyful leap,
Responsive layouts make my heart skip a beat!
Hopping along on media queries, oh what a treat! 🐇✨

– A Rabbit in Code

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a06e7d6 and 3e785f1.

📒 Files selected for processing (1)
  • src/pages/Appointments/AppointmentDetail.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/Appointments/AppointmentDetail.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 3e785f1
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67a43c5549c0e20008c906eb
😎 Deploy Preview https://deploy-preview-10423--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Jacobjeevan Jacobjeevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, go ahead and adjust this as well (add gap/mb or whichever as necessary)

image

@Mahendar0701 Mahendar0701 changed the title Remove extra padding in appointment details page Remove extra padding in appointment details page | Current status dropdown Feb 6, 2025
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2025

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Feb 6, 2025
@rithviknishad rithviknishad merged commit 2175dd3 into ohcnetwork:develop Feb 6, 2025
14 of 15 checks passed
Copy link

github-actions bot commented Feb 6, 2025

@Mahendar0701 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
Status: Done
4 participants