added PatientDetailsTabDemographyGeneralInfo plaggable #10418
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a new plugin component, Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying care-fe with
|
| Latest commit: |
379c394
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7879e4c5.care-fe.pages.dev |
| Branch Preview URL: | https://khavinshankar-feat-add-plugg.care-fe.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Patient/PatientDetailsTab/Demography.tsx(2 hunks)src/pluginTypes.ts(2 hunks)
🧰 Additional context used
🪛 GitHub Check: cypress-run (1)
src/components/Patient/PatientDetailsTab/Demography.tsx
[failure] 143-143:
Property 'id' is missing in type '{ facilityId: string; patientId: string; patientData: Patient; key: string; __name: "PatientDetailsTabDemographyGeneralInfo"; }' but required in type '{ facilityId: string; id: string; patientData: Patient; }'.
🪛 GitHub Actions: Cypress Tests
src/components/Patient/PatientDetailsTab/Demography.tsx
[error] 143-143: Property 'id' is missing in type '{ facilityId: string; patientId: string; patientData: Patient; key: string; __name: "PatientDetailsTabDemographyGeneralInfo"; }' but required in type '{ facilityId: string; id: string; patientData: Patient; }'.
[warning] ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time.
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Redirect rules - care-ohc
- GitHub Check: Header rules - care-ohc
- GitHub Check: Pages changed - care-ohc
- GitHub Check: Test
- GitHub Check: CodeQL-Build
🔇 Additional comments (3)
src/pluginTypes.ts (2)
44-48: LGTM! Well-structured type definition.The type definition is clear and follows the established patterns with appropriate props for the component's purpose.
58-58: LGTM! Clean integration into SupportedPluginComponents.The new component type is properly integrated into the supported components list.
src/components/Patient/PatientDetailsTab/Demography.tsx (1)
202-230: Verify impact of future Geo_Org replacement.There's a TODO comment about replacing the current implementation with Geo_Org. Please verify that this future change won't affect the newly added plugin component's functionality.
🧰 Tools
🪛 GitHub Actions: Cypress Tests
[warning] ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time.
| <PLUGIN_Component | ||
| key="patient_details_tab__demography__general_info" | ||
| __name="PatientDetailsTabDemographyGeneralInfo" | ||
| {...props} | ||
| />, |
There was a problem hiding this comment.
Fix prop type mismatch causing build failure.
The component requires an id prop, but receives patientId from the spread props. This type mismatch is causing the build to fail.
Apply this fix to resolve the type error:
<PLUGIN_Component
key="patient_details_tab__demography__general_info"
__name="PatientDetailsTabDemographyGeneralInfo"
- {...props}
+ facilityId={facilityId}
+ id={id}
+ patientData={patientData}
/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <PLUGIN_Component | |
| key="patient_details_tab__demography__general_info" | |
| __name="PatientDetailsTabDemographyGeneralInfo" | |
| {...props} | |
| />, | |
| <PLUGIN_Component | |
| key="patient_details_tab__demography__general_info" | |
| __name="PatientDetailsTabDemographyGeneralInfo" | |
| facilityId={facilityId} | |
| id={id} | |
| patientData={patientData} | |
| />, |
🧰 Tools
🪛 GitHub Check: cypress-run (1)
[failure] 143-143:
Property 'id' is missing in type '{ facilityId: string; patientId: string; patientData: Patient; key: string; __name: "PatientDetailsTabDemographyGeneralInfo"; }' but required in type '{ facilityId: string; id: string; patientData: Patient; }'.
🪛 GitHub Actions: Cypress Tests
[error] 143-143: Property 'id' is missing in type '{ facilityId: string; patientId: string; patientData: Patient; key: string; __name: "PatientDetailsTabDemographyGeneralInfo"; }' but required in type '{ facilityId: string; id: string; patientData: Patient; }'.
[warning] ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time.
…s' of github.com:ohcnetwork/care_fe into khavinshankar/feat/add-pluggable-to-display-abha-details
CARE
|
||||||||||||||||||||||||||||
| Project |
CARE
|
| Branch Review |
khavinshankar/feat/add-pluggable-to-display-abha-details
|
| Run status |
|
| Run duration | 05m 56s |
| Commit |
|
| Committer | Khavin Shankar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
|
LGTM, conditional approved it ohcnetwork/care_abdm_fe#6 (comment) |
gigincg
deleted the
khavinshankar/feat/add-pluggable-to-display-abha-details
branch
|
@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Summary by CodeRabbit