Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaked Print Preview Width #10410

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Tweaked Print Preview Width #10410

merged 1 commit into from
Feb 6, 2025
+2 −2

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Feb 5, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Adjusted the initial display scaling for a more consistent preview.
    • Enhanced the layout to adapt responsively across different screen sizes for improved viewing on various devices.

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner February 5, 2025 09:47
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025 •
edited
Loading

Walkthrough

The changes update the PrintPreview component in the CAREUI codebase. The normalScale variable is modified from a value of 0.44 to 1, and the styling of a key div element is adjusted by replacing the fixed class w-[50rem] with the responsive class xl:w-[50rem]. These modifications aim to improve the layout and mobile view responsiveness of the print preview page without altering any public interfaces.

Changes

File Change Summary
src/CAREUI/misc/PrintPreview.tsx Updated normalScale from 0.44 to 1 and changed div width from fixed w-[50rem] to responsive xl:w-[50rem] to support mobile responsiveness.

Assessment against linked issues

Objective Addressed Explanation
Print preview page mobile responsiveness (#10340) ✅
Missing resource details (created by/last modified IDs) and comment box user details (#10340) ❌ No changes address the missing details in the resource pages.
Edit resource prefill for current status and assigned facility (#10340) ✅

Possibly related PRs

Suggested reviewers

  • rithviknishad

Poem

In the garden of code, I nibble away,
Scaling shifts from small to bright display,
A mobile view refined with responsive cheer,
Fixed widths now dance when screens are near,
With twitching whiskers and a happy hop in place,
I celebrate these changes with a rabbit’s grace!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 8915956
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67a333b83905000008ce8db8
😎 Deploy Preview https://deploy-preview-10410--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot]
coderabbitai bot reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/CAREUI/misc/PrintPreview.tsx (1)

32-32: LGTM! Consider adding explicit width for smaller breakpoints.

The change from w-[50rem] to xl:w-[50rem] improves mobile responsiveness by removing the fixed width constraint on smaller screens. The container will now naturally flow with the viewport width below the xl breakpoint.

Consider explicitly defining widths for smaller breakpoints for more controlled responsive behavior:

-      <div className="mx-auto my-8 xl:w-[50rem] border rounded-xl border-gray-200 shadow-2xl overflow-hidden">
+      <div className="mx-auto my-8 w-full md:w-[40rem] lg:w-[45rem] xl:w-[50rem] border rounded-xl border-gray-200 shadow-2xl overflow-hidden">
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d9273d and 8915956.

📒 Files selected for processing (1)
  • src/CAREUI/misc/PrintPreview.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc
  • GitHub Check: Pages changed - care-ohc
  • GitHub Check: Test
  • GitHub Check: CodeQL-Build
  • GitHub Check: cypress-run (1)
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (1)
src/CAREUI/misc/PrintPreview.tsx (1)

27-27: LGTM! Verify zoom behavior across different screen sizes.

The change from 0.44 to 1 provides a more natural initial zoom level at 100%. This should improve the default viewing experience.

Please test the print preview on different screen sizes to ensure the zoom level remains appropriate, particularly on mobile devices.

@nihal467
Copy link
Member

nihal467 commented Feb 6, 2025

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Feb 6, 2025
@rithviknishad rithviknishad merged commit 2c6f5db into ohcnetwork:develop Feb 6, 2025
15 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in resource page
3 participants
@Jacobjeevan @nihal467 @rithviknishad