-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed the remove button #10400
removed the remove button #10400
Conversation
WalkthroughThe pull request removes the functionality that allowed users to remove a questionnaire from the form. This change involves deleting the conditional rendering and click handler for the remove button in the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant Q as QuestionnaireForm
U->>Q: Load form
Note right of Q: Remove button is not rendered
U->>Q: Interact with form (no remove action available)
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
the issue says about removing it only for structured questions edit pages and not in questionnaire forms. there is no way to remove questionnaires now after adding one with this method. |
I am sorry @rithviknishad but I am unable to understand. What I understood from the issue was that I should hide the remove button. It would be very kind of you if you could please explain what is needed to be done. Thank you!! |
@Sourav6971 so the If you go to the questionnaire form these sources (see screenshot below), we should be able to remove or add questionnaires (such questionnaires may or may not contain structured questions in this) ![]() However, if you land to the questionnaire form from one of these edit buttons (see screenshot below; these are always structured questions), we are simply reusing the questionnaire form component to show these, but remove and add option should not be present. Here are the list of structured question types: care_fe/src/types/questionnaire/question.ts Lines 19 to 26 in 5d9273d
![]() |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
The expected behavior after merging the request:-
Summary by CodeRabbit