Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the remove button #10400

Closed
wants to merge 2 commits into from
Closed

Conversation

Sourav6971
Copy link

@Sourav6971 Sourav6971 commented Feb 4, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

The expected behavior after merging the request:-

Screenshot 2025-02-05 010959

Summary by CodeRabbit

  • Refactor
    • Removed the option for users to delete a questionnaire from the form.
    • Simplified the interface by cleaning up unused elements.

@Sourav6971 Sourav6971 requested a review from a team as a code owner February 4, 2025 19:41
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

The pull request removes the functionality that allowed users to remove a questionnaire from the form. This change involves deleting the conditional rendering and click handler for the remove button in the QuestionnaireForm component. Additionally, the unused CareIcon import has been removed. The overall component structure and functionality remain intact aside from these removals.

Changes

File Change Summary
src/components/Questionnaire/QuestionnaireForm.tsx Removed the conditional rendering and click handler for the remove button; eliminated the CareIcon import

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant Q as QuestionnaireForm
    U->>Q: Load form
    Note right of Q: Remove button is not rendered
    U->>Q: Interact with form (no remove action available)
Loading

Assessment against linked issues

Objective Addressed Explanation
Remove the remove button on the edit question page (#10310)

Suggested labels

changes required

Suggested reviewers

  • rithviknishad

Poem

Hopping along in lines of code,
I bid farewell to a faulty mode.
The remove button’s now gone astray,
Bugs vanish hopping in my way.
Code is clean—hip hip hooray! 🐰

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d9273d and 457debf.

📒 Files selected for processing (1)
  • src/components/Questionnaire/QuestionnaireForm.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/components/Questionnaire/QuestionnaireForm.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Redirect rules - care-ohc
  • GitHub Check: Header rules - care-ohc

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 457debf
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67a26d9c0fb91300088acdf0
😎 Deploy Preview https://deploy-preview-10400--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member

the issue says about removing it only for structured questions edit pages and not in questionnaire forms.

there is no way to remove questionnaires now after adding one with this method.

@rithviknishad rithviknishad reopened this Feb 4, 2025
@rithviknishad rithviknishad added invalid This doesn't seem right changes required labels Feb 4, 2025
@Sourav6971
Copy link
Author

I am sorry @rithviknishad but I am unable to understand. What I understood from the issue was that I should hide the remove button. It would be very kind of you if you could please explain what is needed to be done. Thank you!!

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 4, 2025
@rithviknishad
Copy link
Member

rithviknishad commented Feb 5, 2025

@Sourav6971 so the QuestionnaireForm component which you've edited (rendered through EncounterQuestionnaire and many more places) is a reusable component and is being used in multiple places for slightly different use cases.

If you go to the questionnaire form these sources (see screenshot below), we should be able to remove or add questionnaires (such questionnaires may or may not contain structured questions in this)

image

However, if you land to the questionnaire form from one of these edit buttons (see screenshot below; these are always structured questions), we are simply reusing the questionnaire form component to show these, but remove and add option should not be present.

Here are the list of structured question types:

export type StructuredQuestionType =
| "allergy_intolerance"
| "medication_request"
| "medication_statement"
| "symptom"
| "diagnosis"
| "encounter"
| "appointment";

image

@rithviknishad rithviknishad removed question Further information is requested needs-triage labels Feb 5, 2025
@Sourav6971 Sourav6971 closed this by deleting the head repository Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the remove button the edit question page
2 participants