Filter allergies by encounter if encounter is marked as completed #10397

rithviknishad · 2025-02-04T18:16:11Z

Proposed Changes

Filter allergies by encounter if encounter is marked as completed

cc: @vigneshhari

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced the allergy information display by incorporating encounter status, ensuring data is more context-specific.
- Updated the encounter updates view to pass encounter status for more consistent results.
Refactor
- Simplified the logic for displaying the edit option, now based solely on facility presence for a smoother user experience.

coderabbitai · 2025-02-04T18:16:20Z

Caution

Review failed

The pull request is closed.

Walkthrough

The changes add a new encounterStatus property to the AllergyListProps interface and update the AllergyList component to incorporate this property in its query logic. The query key for fetching allergy data now includes encounterStatus, and the query parameters conditionally include encounterId based on the status. Additionally, the AllergyListLayout now renders the edit link based solely on the presence of facilityId. The EncounterUpdatesTab component is updated to pass the new encounterStatus prop to AllergyList.

Changes

File(s)	Change Summary
`src/components/Patient/allergy/list.tsx`	Added `encounterStatus` to `AllergyListProps` and updated `AllergyList` to include it in the query key and query parameters. Also, updated edit link logic.
`src/pages/Encounters/tabs/EncounterUpdatesTab.tsx`	Modified the component to pass the `encounterStatus` from the encounter object to the `AllergyList` component.

Sequence Diagram(s)

sequenceDiagram
    participant Tab as EncounterUpdatesTab
    participant List as AllergyList
    participant Query as useQuery

    Tab->>List: Pass encounterStatus (from encounter.status)
    List->>Query: Execute query with key including encounterStatus
    Query-->>List: Return allergy data

Possibly related PRs

Fix: Allergy count to Updated to has allergies text #9399: The changes in this PR are related to the addition of the encounterStatus prop in the AllergyList component.
Enhance AllergyQuestion component with improved UI and functionality.… #9647: Involves modifications to component props, specifically the addition of new properties to enhance functionality, similar to this PR.
Migration to useQuery: Removed PaginatedList.tsx and Update Dependent Components #10350: The changes in this PR are directly related to the addition of the encounterStatus prop in the AllergyList component.

Suggested labels

tested

Suggested reviewers

rithviknishad

Poem

Oh, what joy hops in the code,
A new prop here, a tweak bestowed.
Encounter status now leads the way,
In queries bright, all data may sway.
I’m a rabbit cheerfully on the run – 🐰
Celebrating changes under the coding sun!
Hop on, dear coder, this update is fun!

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b816e20 and c242c96.

📒 Files selected for processing (1)

src/components/Patient/allergy/list.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-04T18:16:31Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`c242c96`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a25ccb4b40f500086129a6
😎 Deploy Preview	https://deploy-preview-10397--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-04T18:17:25Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`c242c96`
Status:	✅ Deploy successful!
Preview URL:	https://4a9097b9.care-fe.pages.dev
Branch Preview URL:	https://rithviknishad-feat-filter-al.care-fe.pages.dev

View logs

cypress · 2025-02-04T18:32:22Z

CARE Run #4610

Run Properties: Passed #4610 • c242c96ff7: Filter allergies by encounter if encounter is marked as completed

Project	`CARE`
Branch Review	`rithviknishad/feat/filter-allergies-if-encounter-completed`
Run status	`Passed #4610`
Run duration	`06m 05s`
Commit	`c242c96ff7: Filter allergies by encounter if encounter is marked as completed`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`10`
View all changes introduced in this branch ↗︎

nihal467 · 2025-02-06T06:37:36Z

Linked Backend : ohcnetwork/care@f6fbaee

github-actions · 2025-02-06T06:40:02Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Filter allergies by encounter if encounter is marked as completed

0b3279f

rithviknishad requested a review from a team as a code owner February 4, 2025 18:16

rithviknishad added 2 commits February 4, 2025 23:52

fix type

b816e20

show edit button only if encounter id is present

c242c96

rithviknishad requested review from bodhish and amjithtitus09 February 4, 2025 18:38

shivankacker approved these changes Feb 5, 2025

View reviewed changes

nihal467 added the needs review label Feb 6, 2025

amjithtitus09 approved these changes Feb 6, 2025

View reviewed changes

amjithtitus09 merged commit c65f395 into develop Feb 6, 2025
21 of 22 checks passed

amjithtitus09 deleted the rithviknishad/feat/filter-allergies-if-encounter-completed branch February 6, 2025 06:39

coderabbitai bot mentioned this pull request Feb 10, 2025

Added confirmation before marking encounter as complete #10523

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter allergies by encounter if encounter is marked as completed #10397

Filter allergies by encounter if encounter is marked as completed #10397

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading

nihal467 commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

Filter allergies by encounter if encounter is marked as completed #10397

Filter allergies by encounter if encounter is marked as completed #10397

Conversation

rithviknishad commented Feb 4, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 4, 2025 • edited Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 4, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Feb 4, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

cypress bot commented Feb 4, 2025 • edited Loading

CARE Run #4610

nihal467 commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

rithviknishad commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 4, 2025 •

edited

Loading

cypress bot commented Feb 4, 2025 •

edited

Loading